Changes in closing status

[nicdev007]

Hi Ivan/Kieran,

Just a quick question:

Can i change (I.e. rename/delete/add) the entries in the database "sit_closingstatus"?, if i can then is there a specific naming rule, i noticed they are all str.... meaning they may trigger events??

or will any changes cause some irrepairable damage? In fact we need to make these options less and we need to customise them to something more relevant for our situation.

In fact the team wants to use this to clasify also the relevance of the incident;

for instance:

If we have an incident created from e-mail, and it is not our scope/job to answer we would like to close it with something like "Sales issue", or "training issue", and then we could later track how many such call we have relates to these "sub reasons" instead of just "unsupported"

Thanks in advance
Nico

[nicdev007]

Hi Ivan/Kieran,

Just a quick question:

Can i change (I.e. rename/delete/add) the entries in the database "sit_closingstatus"?, if i can then is there a specific naming rule, i noticed they are all str.... meaning they may trigger events??

or will any changes cause some irrepairable damage? In fact we need to make these options less and we need to customise them to something more relevant for our situation.

In fact the team wants to use this to clasify also the relevance of the incident;

for instance:

If we have an incident created from e-mail, and it is not our scope/job to answer we would like to close it with something like "Sales issue", or "training issue", and then we could later track how many such call we have relates to these "sub reasons" instead of just "unsupported"

Thanks in advance
Nico

[xerosis]

Hi NIco,

They're only strXXXX in the database to enable us to lookup the key in the users language. They're fairly arbitrary so you can change them to whatever you want, obviously they won't be translated but I guess it's not really a problem for you.

The only thing to bear in mind (for us as well) is that we might in future update that table which might overwrite your changes. We should probably look into proper customisation. But to answer the question, it won't break anything to change them.

Kieran

[xerosis]

Hi NIco,

They're only strXXXX in the database to enable us to lookup the key in the users language. They're fairly arbitrary so you can change them to whatever you want, obviously they won't be translated but I guess it's not really a problem for you.

The only thing to bear in mind (for us as well) is that we might in future update that table which might overwrite your changes. We should probably look into proper customisation. But to answer the question, it won't break anything to change them.

Kieran

[xerosis]

I've just checked, the code assumes the status starts with 'str' which is bad. So you have two options: I can give you a patch to fix this or you can name it strXXX add a string in your language file, it's up to you.

[xerosis]

I've just checked, the code assumes the status starts with 'str' which is bad. So you have two options: I can give you a patch to fix this or you can name it strXXX add a string in your language file, it's up to you.

[nicdev007]

Hi Kieran,

I have had very interresting feedback from the team after the last week of using the tracker internally (we decided to delay the extended use by our field contacts by a month).

Some feedback was very usefull and some quite arbitrary, but i suppose you cannot keep everyone happy all of the time ;-)

This changing of the closing status, was one of the more useful ones, and i am happy that we can modify it without issue. I will keep our own changelog locally to ensure we keep track of all our changes, for all future upgrades.

The rest of the feedback i will log in Mantis as they are more requests ...

Thank again.

Best regards
Nico

[nicdev007]

Just hit send and then saw your reply. I think i would rather name them strXXX and add the tags in the language files. Just for ref... which language files needs to be modified?

Thanks

[xerosis]

I think you missed my last message so here's the patch so you can choose which method to use:

Index: includes/functions.inc.php
===================================================================
--- includes/functions.inc.php (revision 4107)
+++ includes/functions.inc.php (working copy)
@@ -2079,7 +2079,16 @@
{
$html .= "selected='selected' ";
}
- $html .= "value='{$statuses["id"]}'>{$GLOBALS[$statuses["name"]]}</option>
";
+ $html .= "value='{$statuses["id"]}'>";
+ if (isset($GLOBALS[$statuses['name']]))
+ {
+ $html .= $GLOBALS[$statuses['name']];
+ }
+ else
+ {
+ $html .= $statuses['name'];
+ }
+ $html .= "</option>
";
}
$html .= "</select>
";

[xerosis]

Agh, bad timing again!

It'll need to be added whatever language file your install uses by default.