show recent incidents not working

[luca]

Hi,
trying to view the incident -> recent incidents page i get the following error:

Application Warning [512]
MySQL Query Error: Table 'sit.contacts' doesn't exist in /home/sit/www/report_incidents_recent.php @ line 53 trigger_error()

i went to the report_incidents_recent page and put an echo $sql before line 53 and this is what i get:

SELECT *,s.id AS siteid FROM `sit_sites` AS s, `sit_maintenance` AS m, `sit_supportcontacts` AS sc, `sit_incidents` AS i WHERE s.id = m.site AND ((m.id = sc.maintenanceid AND sc.contactid = i.contact) OR (m.allcontactssupported = 'yes' AND i.contact in (SELECT id FROM contacts WHERE siteid = s.id))) AND i.opened > '1296964379' ORDER BY s.id, i.id

so i changed on line of the query generation from:

Code: Select all

$sql .= "OR (m.allcontactssupported = 'yes' AND i.contact in (SELECT id FROM contacts WHERE siteid = s.id))) ";


to

Code: Select all

$sql .= "OR (m.allcontactssupported = 'yes' AND i.contact in (SELECT id FROM sit_contacts WHERE siteid = s.id))) ";


not sure if this breaks something else...

any comments? file a bug?

[Tomse]

Hello luca,

it does seem like a typo there..
you might want to replace

Code: Select all

$sql .= "OR (m.allcontactssupported = 'yes' AND i.contact in (SELECT id FROM contacts WHERE siteid = s.id))) ";

with

Code: Select all

$sql .= "OR (m.allcontactssupported = 'yes' AND i.contact in (SELECT id FROM {$dbContacts} WHERE siteid = s.id))) ";

if it works for you, can you please log it in mantis with this solution ?

cheers
Tomse

[luca]

works. will report with a link to this thread.

[Tomse]

it's fixed now, and will work from 3.63
thanks for testing

cheers
T

[luca]

thanks for fixing